Skip to content
Snippets Groups Projects
  1. Aug 20, 2021
  2. Aug 06, 2021
  3. Aug 04, 2021
  4. Aug 03, 2021
  5. Jul 29, 2021
  6. Jul 28, 2021
  7. Jul 26, 2021
  8. Jul 23, 2021
  9. Jul 20, 2021
    • Joseph Hwang's avatar
      tools: btmgmt: support quality experiment feature command · e0ea1c9c
      Joseph Hwang authored
      This patch adds the "exp-quality" command to btmgmt to enable/disable
      the Bluetooth quality report.
      e0ea1c9c
    • Joseph Hwang's avatar
      adapter: read quality report feature · 7be40ec8
      Joseph Hwang authored
      
      This patch adds a new UUID for the quality report experimental
      feature. When reading the experimental features, it checks if
      the new feature is supported by the controller and stores the
      value in the quality_report_supported flag of the adapter.
      
      The quality_report_supported flag could be used by the bluetoothd
      to determine if the quality report feature can be enabled.
      
      Reviewed-by: default avatarMiao-chen Chou <mcchou@chromium.org>
      7be40ec8
    • Joseph Hwang's avatar
      monitor: add new Intel extended telemetry events · de6c0c77
      Joseph Hwang authored
      
      This patch adds new Intel extended telemetry events for both ACL and
      SCO/eSCO audio link quality reports.
      
      For SCO/eSCO audio link quality report, it shows something like
      > HCI Event: Vendor (0xff) plen 190  #120 [hci0] 2021-05-31 20:27:50.257
              Vendor Prefix (0x8780)
            Intel Extended Telemetry (0x87)
              Extended Telemetry (0x80): SubOpcode (0x03)
              Extended event type (0x01): Audio Link Quality Report Type(0x05)
              SCO/eSCO connection handle (0x6a): 0x0101
              Packets from host (0x6b): 399
              Tx packets (0x6c): 403
              Rx payload lost (0x6d): 3
              Tx payload lost (0x6e): 0
              Rx No SYNC errors (0x6f): 3 2 3 3 0
              Rx HEC errors (0x70): 0 0 0 0 0
              Rx CRC errors (0x71): 2 0 0 0 0
              Rx NAK errors (0x72): 6 0 0 0 0
              Failed Tx due to Wifi coex (0x73): 6 0 0 0 0
              Failed Rx due to Wifi coex (0x74): 0 0 0 0 0
              Late samples inserted based on CDC (0x75): 0
              Samples dropped (0x76): 0
              Mute samples sent at initial connection (0x77): 0
              PLC injection data (0x78): 0
      
      For ACL audio link quality report, it shows something like
      > HCI Event: Vendor (0xff) plen 142  #120 [hci0] 2021-05-31 20:27:50.261
              Vendor Prefix (0x8780)
            Intel Extended Telemetry (0x87)
              Extended Telemetry (0x80): SubOpcode (0x03)
              Extended event type (0x01): Audio Link Quality Report Type(0x05)
              ACL connection handle (0x4a): 0x0100
              Rx HEC errors (0x4b): 0
              Rx CRC errors (0x4c): 0
              Packets from host (0x4d): 100
              Tx packets (0x4e): 101
              Tx packets 0 retries (0x4f): 89
              Tx packets 1 retries (0x50): 11
              Tx packets 2 retries (0x51): 1
              Tx packets 3 retries (0x52): 0
              Tx packets 4 retries and more (0x53): 0
              Tx DH1 packets (0x54): 0
              Tx DH3 packets (0x55): 0
              Tx DH5 packets (0x56): 0
              Tx 2DH1 packets (0x57): 0
              Tx 2DH3 packets (0x58): 0
              Tx 2DH5 packets (0x59): 0
              Tx 3DH1 packets (0x5a): 6
              Tx 3DH3 packets (0x5b): 0
              Tx 3DH5 packets (0x5c): 94
              Rx packets (0x5d): 272
              ACL link throughput (KBps) (0x5e): 343815
              ACL max packet latency (ms) (0x5f): 20625
              ACL avg packet latency (ms) (0x60): 12
      
      Reviewed-by: default avatarMiao-chen Chou <mcchou@chromium.org>
      de6c0c77
    • Yun-Hao Chung's avatar
      core: fix a possible crash when removing devices · cb53d86b
      Yun-Hao Chung authored
      In probe_service, if the service already exists in device->services, it
      returns the service. This might cause dev_probe and device_probe_profile
      to add a duplicate service into device->services. When removing the
      device, a double-free error might occur.
      
      This patch changes the logic of probe_service so that the same service
      will not be added to a device.
      cb53d86b
  10. Jul 19, 2021
    • Luiz Augusto von Dentz's avatar
      btdev: Fix not checking conditions for LE Set Random Address · 0f849abb
      Luiz Augusto von Dentz authored
      The spec says LE Set Random Address cannot be used when scan is enabled
      or with legacy advertising:
      
      BLUETOOTH CORE SPECIFICATION Version 5.2 | Vol 4, Part E
      page 2480
      
        'If the Host issues this command when any of advertising (created
        using legacy advertising commands), scanning, or initiating are
        enabled, the Controller shall return the error code Command
        Disallowed (0x0C).'
      0f849abb
    • Luiz Augusto von Dentz's avatar
      btdev: Add proper checks for own_addr_type for LE scan/adv · 0356d2a4
      Luiz Augusto von Dentz authored
      own_addr_type 0x01 and 0x03 shall check that a random address has
      properly been set:
      
      BLUETOOTH CORE SPECIFICATION Version 5.2 | Vol 4, Part E
      page 2496:
      
        'If LE_Scan_Enable is set to 0x01, the scanning parameters'
        Own_Address_Type parameter is set to 0x01 or 0x03, and the random
        ddress for the device has not been initialized, the Controller shall
        return the error code Invalid HCI Command Parameters (0x12).'
      
      BLUETOOTH CORE SPECIFICATION Version 5.2 | Vol 4, Part E
      page 2614:
      
        'If Enable is set to 0x01, the scanning parameters' Own_Address_Type
        parameter is set to 0x01 or 0x03, and the random address for the
        device has not been initialized, the Controller shall return the
        error code Invalid HCI Command Parameters (0x12).'
      0356d2a4
Loading