• Daniel Stone's avatar
    gl-renderer: Account for offset in output region translation · 3ebd8704
    Daniel Stone authored
    In 55bcb93f ("gl-renderer: Use helper for conversion to EGL rects"),
    we extracted and lovingly commented the transformation from global to
    output co-ordinate space used for EGL_KHR_swap_buffer_with_damage, into
    a new helper function.
    
    The commenting correctly noted the steps we need to perform the
    transformation: shifting by the output's offset into global space,
    followed by applying the output's scale and rotation transformations.
    
    Unfortunately, the code did not live up to the high standards of the
    comment, and forgot to translate by the output's offset. This meant that
    for multiple outputs, we would probably end up with wildly out-of-bounds
    co-ordinates.
    
    Fix the code to first translate by the output's offset in global space,
    ensuring that both our swap_buffers_with_damage, and our partial_update
    co-ordinate sets, can spark joy for those blessed with more than one
    output.
    Signed-off-by: Daniel Stone's avatarDaniel Stone <daniels@collabora.com>
    3ebd8704
Name
Last commit
Last update
.gitlab-ci Loading commit data...
clients Loading commit data...
compositor Loading commit data...
data Loading commit data...
desktop-shell Loading commit data...
doc Loading commit data...
fullscreen-shell Loading commit data...
include Loading commit data...
ivi-shell Loading commit data...
libweston Loading commit data...
libweston-desktop Loading commit data...
man Loading commit data...
protocol Loading commit data...
remoting Loading commit data...
shared Loading commit data...
tests Loading commit data...
tools/zunitc Loading commit data...
wcap Loading commit data...
xwayland Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
CONTRIBUTING.md Loading commit data...
COPYING Loading commit data...
README.md Loading commit data...
meson.build Loading commit data...
meson_options.txt Loading commit data...
notes.txt Loading commit data...
releasing.txt Loading commit data...
weston.ini.in Loading commit data...