Skip to content

Change padding to be rfc8489 conform

Adnan Elezovic requested to merge adnanel/libnice:master into master

Although this is the smallest problem when it comes to RFC8489 support, it could've been zero padded since the beginning, since RFC 5389 never specified what the padding should be.

For whatever reason it was ' ' (ascii 20) up until now.

Servers which support only RFC 8489 would reject requests generated by libnice due to this, even though the messages are RFC8489 conform, with the only exception in padding.

Padding is defined in rfc8489 as MUST be zero and MUST be ignored - https://www.rfc-editor.org/rfc/rfc8489.html#section-14

While in RFC 5389, padding MUST be ignored, but MAY be any value - https://datatracker.ietf.org/doc/html/rfc5389#section-15

Due to working with servers which assume that STUN requests are RFC8489 conform, their expected hash is calculated with zeroes, so it differs from what libnice is sending.

It would help us immensely to get this merged so that we can ensure compatibility.

Edited by Adnan Elezovic

Merge request reports