Skip to content

conncheck: ensure credentials are set before starting timer

With this patch, we check that all streams have credentials before starting the conncheck timer. A new place to start the timer must be added when remote credentials are set in that case.

Previously, we were with the assumption that credentials were always set before the remote candidates. If remote candidates were obtained first, the conncheck could start and immediately fail due to the lack of credentials. With this patch, we delay the start of the conncheck timer, until we have some pairs to check, and credentials, on a per-stream basis.

This problem is specific to RFC5245 compatibility mode, where credentials are set per stream, and not per remote candidate. This commit alter the agent behaviour in this compatibility mode only.

This implements a comment from mr !182 (merged)

Merge request reports