Skip to content
  • John Chadwick's avatar
    test: Make udev_properties array fixed-size. · a7d2b749
    John Chadwick authored and Peter Hutterer's avatar Peter Hutterer committed
    The udev_properties array is currently variable length, which causes the
    tests to invoke undefined behavior on empty lists, as it attempts to
    access the first array item to check if the key is NULL, which is an out
    of bounds read and will fail when the struct alignment happens to line
    up such that there is no padding after the list in the empty list case.
    
    By making the udev_properties array 32 items long, it can encapsulate
    every existing case, with only a fairly small amount of memory overhead,
    and without requiring every single `TEST_DEVICE` call to initialize
    `udev_properties`.
    
    (cherry picked from commit b71a1b6e)
    a7d2b749