Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L libinput
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 141
    • Issues 141
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • libinput
  • libinput
  • Merge requests
  • !735

clickpad: Protect against ghost-clicks on click-pad

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Andras Szalai requested to merge sly010/libinput:xps15touchpad into main Jan 10, 2022
  • Overview 20
  • Commits 1
  • Pipelines 6
  • Changes 5

Background:

The 2020 (and maybe 2019) Dell XPS15 has a notoriously "loose" touchpad and a body that "flexes" under its own weight. i.e. https://www.youtube.com/results?search_query=xps+15+touchpad+loose+click

Whenever I lift the laptop with one hand, the body flexes more than the touchpad, which causes a click. I can basically walk around holding an open laptop and it will reliably click every few steps.

This small change fixed the problem for me, it basically checks that there are some fingers on the clickpad. This however probably breaks touchpads with discrete buttons and maybe other cases that I don't know of? Can this be made generic, or should I create a quirk that can be enabled on specific models?

I am happy to do whatever way you think is best.

Edited Feb 15, 2022 by Andras Szalai
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: xps15touchpad