Skip to content

WIP: advanced thumb detection v2

Peter Hutterer requested to merge whot/libinput:wip/advanced-thumb-detection-v2 into master

This is !215 (closed) rebased and cleaned up, as much as possible anyway. This is not yet the final product, but getting close to mergable.

@mdmayfield please look at the commits starting with "touchpad: basic thumb detection within gestures". The work before is cleanup work and mostly mechanical, after that it gets interesting. Commits with SQUASHME need to be squashed in, they just highlight bugs I found but that change something significant, so I'd like a second pair of eyes. The majority of the effort is in the "revamp" commit, I couldn't break it down any further.

fwiw, I cleaned a few things up as I diffed things, so it's not 100% the same code.

I'm a bit confused about "touchpad: remove pinch exit strategy", this is a revert of a previous commit "Add thumb detection within pinch". Can we just drop this outright?

Remaining test case failures:

  • touchpad_speed_ignore_finger - that speed code is broken since we clip at 10 but you check for >= 10
  • touchpad_speed_ignore_finger_edgescroll - same thing, I think
  • touchpad_thumb_area_large_move - that code was removed by the revamp, so right now moving the thumb around in the area doesn't trigger any events, that's wrong IMO.
Edited by Peter Hutterer

Merge request reports