Skip to content
Snippets Groups Projects

tests: Fix dbusmock AddDevice calls to include optional argument

Merged Benjamin Berg requested to merge benzea/fix-ci-2 into master
1 unresolved thread

The dbusmock code checks that all parameters wanted by the dbus signature are given. As such, pass them, even though the parameters is optional on the python side.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Benjamin Berg added 2 commits

    added 2 commits

    • 3633dbaa - 1 commit from branch master
    • ae04fa98 - tests: Fix dbusmock AddDevice calls to include optional argument

    Compare with previous version

  • merged

    • Looks like we still have this happening in some architectures for some weird reason:

      503/531 fprintd:+test_fprintd_utils+TestFprintdUtilsVerify / TestFprintdUtilsVerify.test_fprintd_verify_any_finger_no_identification                                                           FAIL             0.47s   exit status 1
      10:29:35 G_DEBUG=fatal-criticals TOPSRCDIR=/<<PKGBUILDDIR>> G_MESSAGES_DEBUG=all MALLOC_CHECK_=2 MALLOC_PERTURB_=88 FPRINT_BUILD_DIR=/<<PKGBUILDDIR>>/obj-powerpc-linux-gnu/src G_SLICE=always-malloc /usr/bin/python3 /<<PKGBUILDDIR>>/tests/test_fprintd_utils.py TestFprintdUtilsVerify.test_fprintd_verify_any_finger_no_identification
      ----------------------------------- output -----------------------------------
      Using template from /<<PKGBUILDDIR>>/tests/dbusmock/fprintd.py
      Using tools from /<<PKGBUILDDIR>>/obj-powerpc-linux-gnu/src/../utils/
      test_fprintd_verify_any_finger_no_identification (__main__.TestFprintdUtilsVerify) ... ERROR
      
      ======================================================================
      ERROR: test_fprintd_verify_any_finger_no_identification (__main__.TestFprintdUtilsVerify)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/<<PKGBUILDDIR>>/tests/test_fprintd_utils.py", line 197, in setUp
          self.setup_device()
        File "/<<PKGBUILDDIR>>/tests/test_fprintd_utils.py", line 90, in setup_device
          self.device_path = self.obj_fprintd_mock.AddDevice(
        File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 141, in __call__
          return self._connection.call_blocking(self._named_service,
        File "/usr/lib/python3/dist-packages/dbus/connection.py", line 652, in call_blocking
          reply_message = self.send_message_with_reply_and_block(
      dbus.exceptions.DBusException: org.freedesktop.DBus.Error.InvalidArgs: Invalid arguments: More items found in D-Bus signature than in Python arguments
      
      ----------------------------------------------------------------------
      Ran 1 test in 0.359s

      powerpc and others still fail also with this commit added.

    • That is in the (shared) setup routine. If that fails, then a lot of the tests should be failing ...

      Are you sure you pulled in the commit from this MR?

    • Yeah, sure... I feel it could be because such archs have not yet the same version of dbus components we depend on?

    • I was looking at the others link, and those runs seem to have passed fine. Maybe I am just missing something, but didn't see failures.

    • Bah, you're right... I just checked it when there was a previous failure apparently... Sorry for the noise -_-

    • Please register or sign in to reply
Please register or sign in to reply
Loading