Don't try to clear storage on devices without internal storage
This change prevents warnings like 'Failed to clear storage before first enrollment: Device has no storage.'.
Merge request reports
Activity
Please register or sign in to reply
Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.
The migration is almost done, at least the rest should happen in the background. There are still a few technical difference between the old cluster and the new ones, and they are summarized in this issue. Please pay attention to the TL:DR at the end of the comment.
This change prevents warnings like 'Failed to clear storage before first enrollment: Device has no storage.'.
Hah, good point. Luckily it was just a warning, but it is good to add the appropriate check.
We could also directly check for FP_DEVICE_FEATURE_STORAGE_CLEAR
. That check should be equivalent (a device should always offer one of the features, i.e. list and/or clear).
merged
Huh, in case you got the CI failure. Not sure what is happening, it must be a fallout of a python-dbusmock fix that I made a while ago …
btw. around here we usually wrap git commit messages at 72 characters or so. Also, adding a new line after the header.
No big deal, just thought I would note it, as I happened to see it in the history.