Skip to content
Snippets Groups Projects

Don't try to clear storage on devices without internal storage

Merged Julian Vennen requested to merge JulianVennen/fprintd:master into master

This change prevents warnings like 'Failed to clear storage before first enrollment: Device has no storage.'.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hah, good point. Luckily it was just a warning, but it is good to add the appropriate check.

    We could also directly check for FP_DEVICE_FEATURE_STORAGE_CLEAR. That check should be equivalent (a device should always offer one of the features, i.e. list and/or clear).

  • merged

  • Huh, in case you got the CI failure. Not sure what is happening, it must be a fallout of a python-dbusmock fix that I made a while ago …

  • btw. around here we usually wrap git commit messages at 72 characters or so. Also, adding a new line after the header.

    No big deal, just thought I would note it, as I happened to see it in the history.

Please register or sign in to reply
Loading