Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Kenneth Graunke
  • mesamesa
  • Merge requests
  • !16

ibc/binary: Fix the calculation of "compressed"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jason Ekstrand requested to merge jekstrand/mesa:heads/refs/ibc/fix-compressed into ibc Nov 05, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

We determine whether or not an instruction is compressed based on how many registers it writes. We compute this value based on the byte mask of bytes written by the instruction. In particular, whether we write to just one register or tso. Unfortunately, we computed this byte mask by left-shifting a 32-bit constant so we never saw any writes to the second register. 🤦

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: heads/refs/ibc/fix-compressed