Skip to content

microsoft/compiler: do not require samplers to start at binding 0

Erik Faye-Lund requested to merge d3d12-fixup-sampler-index into msclc-d3d12

@gerddie: This fixes some asserts that triggers after !33 (merged). This part is a long-standing bug that just happened to get triggered now.

But this isn't the end of the story at all; we end up using PIPE_FORMAT_X24S8_UINT, which gets us DXGI_FORMAT_UNKNOWN for the sampler-views, and implementing that using DXGI_FORMAT_D24_UNORM_S8_UINT ends up giving me a corrupt shader.

I also think that d3d12_get_sampler_format_for_ds no longer does the right thing now that we need to sample stencil textures...

Merge request reports

Loading