- May 17, 2014
-
-
Ian Romanick authored
Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com>
-
Brian Paul authored
We allocate dispatch tables for BeginEnd and OutsideBeginEnd. But when we destroy the context we were freeing the BeginEnd and Exec tables. If Exec==BeginEnd we did a double-free. This would happen if the context was destroyed while inside a glBegin/End pair. Now free the BeginEnd and OutsideBeginEnd pointers. Cc: "10.1", "10.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Michel Dänzer <michel.daenzer@amd.com> (cherry picked from commit ef6b6658)
-
Michel Dänzer authored
Fixes the valgrind report below and random crashes with piglit on radeonsi. ==30005== Conditional jump or move depends on uninitialised value(s) ==30005== at 0xB13584E: st_translate_program (st_glsl_to_tgsi.cpp:5100) ==30005== by 0xB14698B: st_translate_fragment_program (st_program.c:747) ==30005== by 0xB14777D: st_get_fp_variant (st_program.c:824) ==30005== by 0xB11219C: get_color_fp_variant (st_cb_drawpixels.c:1042) ==30005== by 0xB1131AE: st_DrawPixels (st_cb_drawpixels.c:1154) ==30005== by 0xAFF8806: _mesa_DrawPixels (drawpix.c:162) ==30005== by 0x4EB86DB: stub_glDrawPixels (generated_dispatch.c:6640) ==30005== by 0x4F1DF08: piglit_visualize_image (piglit-util-gl.c:1574) ==30005== by 0x40691D: draw_image_to_window_system_fb(int, bool) (draw-buffers-common.cpp:733) ==30005== by 0x406C8B: draw_reference_image(bool, bool) (draw-buffers-common.cpp:854) ==30005== by 0x40722A: piglit_display (alpha-to-coverage-dual-src-blend.cpp:117) ==30005== by 0x4EA7168: run_test (piglit_fbo_framework.c:52) Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Brian Paul <brianp@vmware.com> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> (cherry picked from commit 2bab9597)
-
Topi Pohjolainen authored
Cc: "10.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> (cherry picked from commit d45fadf1)
-
Topi Pohjolainen authored
Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 475216a4)
-
Topi Pohjolainen authored
This is effective only on gen8 for now as previous generations still go through blorp. Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit b18f6b9b)
-
Topi Pohjolainen authored
v2: Create the intel renderbuffer with level hardcoded to zero instead of overriding it in the surface state configuration. Also moved the dimension adjustments for tiling, mip level, msaa into the render buffer creation. Finally prepares for another blit path needed for miptree updownsampling. v3 (Ken): Dropped unnecessary memory context for "ralloc_asprintf()" Cc: "10.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> (cherry picked from commit d1829bad)
-
Topi Pohjolainen authored
Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit 2a549c43) Note: This patch was cherry picked so that the next patch would build.
-
Topi Pohjolainen authored
v2: Configure stencil directly for final dimensions instead of adjusting bit by bit for tiling, mip level and msaa. v3 (Ken): Used non-static constant for horizontal alignment Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 9d752c09)
-
Topi Pohjolainen authored
v2: Allow hardware to offset accesses to individual layers. Also leave the mip-level overriding for the creator of the intel renderbuffer to handle. Merged with "i965/gen8: Allow stencil buffers to be configured as single sampled" Ken: I left the "_mesa_problem()" still in place. I think it is clearer to remove it in a separate patch. Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 36caae48)
-
Topi Pohjolainen authored
v2: Use intel_mipmap_tree::total_width in order to get correct alignment automatically. Also use "mt->total_height / mt->physical_depth0" as surface height allowing hardware to offset to correct slice. Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 6aefaa4e)
-
Jordan Justen authored
mt->format is of type mesa_format, and therefore can't be used with _mesa_base_fbo_format which requires a GLenum input. On gen8, this fixes various piglit fbo-depthstencil tests with samples > 1. Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: "10.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 103057b2)
-
Roland Scheidegger authored
Previously the code used the total number of ubos being declared in the linked program (so the ubos of all shaders combined), use the number from the particular shader instead. This fixes an assertion failure with piglit arb_uniform_buffer_object-maxblocks seen in llvmpipe since 8a9f5ecd as it now emits code for each declared buffer, not just the ones actually used. CC: "10.1 10.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit 3e817e7e)
-
Emil Velikov authored
Both changes landed in 10.2, and for people not following the development cycle these will come as a surprise. Note that the pipe_* interface is not stable. Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> Acked-by:
Rob Clark <robclark@freedesktop.org> (cherry picked from commit e48054d0)
-
Emil Velikov authored
Commit 11623be9 was meant to have this hunk, which I accidently dropped during git rebase. Cc: 10.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by:
Julien Cristau <jcristau@debian.org> Reviewed-by:
Matt Turner <mattst88@gmail.com> Reviewed-by:
Jonathan Gray <jsg@jsg.id.au> (cherry picked from commit f57d0921)
-
Michel Dänzer authored
Bring it back in line with r600g. I broke this in the original radeonsi bringup. :( Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78537 Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Reviewed-by:
Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit c5828b05)
-
Jonathan Gray authored
The M_PI*f macros used a preprocessor paste to append 'f' to M_PI defines, which works if the values are only numbers but breaks on OpenBSD where M_PI definitions have casts and brackets to meet requirements of a future version of POSIX, http://austingroupbugs.net/view.php?id=801 http://austingroupbugs.net/view.php?id=828 Simplify the M_PI*f macros by using casts directly in the defines as suggested by Kenneth Graunke. Cc: "10.2" <mesa-stable@lists.freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78665 Reviewed-by:
Matt Turner <mattst88@gmail.com> Signed-off-by:
Jonathan Gray <jsg@jsg.id.au> (cherry picked from commit 0c0bbe77)
-
Kenneth Graunke authored
The point of copytexsubimage_using_blit_framebuffer is to use a hardware accelerated BlitFramebuffer path. If that fails, we shouldn't do a swrast blit---we should try our CTSI fallback code. This is especially important for i965 and GLES, where we don't even create a swrast context. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77705 Signed-off-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> Cc: "10.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit bd44ac8b)
-
Kristian Høgsberg authored
We're moving towards requiring interface additions to be appended to the end of the interface block. No functional change, opcodes are assigned as before, but version 2 additions are now grouped together, which prevents a scanner warning. Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Kristian Høgsberg <krh@bitplanet.net> (cherry picked from commit 06842d43)
-
Topi Pohjolainen authored
Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 4dc9c314)
-
Topi Pohjolainen authored
Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit a2952315)
-
Topi Pohjolainen authored
Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit ac4db0aa)
-
Topi Pohjolainen authored
Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 3a43cd0c)
-
Topi Pohjolainen authored
Cc: "10.2" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 4a92ad55)
-
- May 14, 2014
-
-
Jordan Justen authored
The depth extent field is used to limit the allowed slice range that can be rendered to. With the previous setting, only slice 0 could be rendered. This fixes piglit amd_vertex_shader_layer-layered-depth-texture-render. Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> (cherry picked from commit c51c1928)
-
Jordan Justen authored
Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> (cherry picked from commit 294ada2f)
-
Jordan Justen authored
Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> (cherry picked from commit e6d6ed55)
-
Jordan Justen authored
Fixes piglit's 'gl-3.2-layered-rendering-clear-color-all-types 3d mipmapped' Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> (cherry picked from commit e47d08ad)
-
Jordan Justen authored
If blorp is disabled for color clears, then piglit's 'gl-3.2-layered-rendering-clear-color-all-types 3d mipmapped' will fail. Currently, gen8 fails similarly on this test because gen8 does not use blorp. Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Chris Forbes <chrisf@ijw.co.nz> (cherry picked from commit b875f39e)
-
Same issues as the previous commit fixed for Gen7: - Bogus physical->logical layer conversion; depth/stencil surfaces are still IMS layout on Gen8. - mt_layer ignored in layered rendering case, which breaks handling of views with MinLayer. - Render target array extent not set correctly for arrays. I'm not able to test this one since I can't get a Broadwell yet, but it's the same set of fixes as for Gen7. V2: Restore the MAX2() to account for zero depth/layer_count. Signed-off-by:
Chris Forbes <chrisf@ijw.co.nz> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 23e9f065)
-
Again, a few problems: - Layered attachments did not honor MinLayer. - Non-layered MSAA attachments rendered to the wrong layer due to dividing by the layer count. All depth buffers use the IMS layout, so the physical layer count == logical layer count. - Layered attachments were not limited to irb->layer_count, so we could render off the end of the texture. V2: Restore the MAX2() to account for zero depth/layer_count. Signed-off-by:
Chris Forbes <chrisf@ijw.co.nz> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 77d55ef4)
-
Fixing the same issues the previous commit does for Gen7. Note that I can't test this one, since I don't have a Broadwell. V2: Restore the MAX2() to account for zero depth/layer_count. Signed-off-by:
Chris Forbes <chrisf@ijw.co.nz> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 9269ea59)
-
There were a few problems here, which mostly just broke layered rendering into a view: - Render target view extent was always set to be == depth. This is benign for non-layered-rendering, but allows writes off the end of the render target for layered rendering, which ends badly. - Layered rendering did not honor the mt_layer setting, so would not properly handle MinLayer being set on a view. V2: Restore the MAX2() to account for zero depth/layer_count. Signed-off-by:
Chris Forbes <chrisf@ijw.co.nz> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit dd43900b)
-
- May 13, 2014
-
-
Ilia Mirkin authored
Need to adjust coordinates since the shader receives the array index as depth in z, but the TEX instruction expects it to be the second coordinate for a 1D array texture. This fixes fbo-generatemipmap-array. Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Ben Skeggs <bskeggs@redhat.com> Cc: "10.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 8baed872)
-
Ilia Mirkin authored
Fixes the new logic of the conditional rendering piglit test. Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Ben Skeggs <bskeggs@redhat.com> Cc: "10.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 4467c0c9)
-
Ilia Mirkin authored
Also make sure that pipe_blit_info gets zero'd out so that query isn't accidentally left enabled. Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Cc: "10.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 64a7ddf4)
-
Ilia Mirkin authored
Previously the implication was that queries should be disabled during blits. However glBlitFramebuffer() is supposed to obey the current query, and this new bit will indicate that to the driver. Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Cc: "10.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 752ce0af)
-
Ilia Mirkin authored
Different textures may be bound to each slot for each stage. So we need to be able to upload ms parameters for each one without stages overwriting each other. Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Ben Skeggs <bskeggs@redhat.com> Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 863573b9)
-
Ilia Mirkin authored
Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Ben Skeggs <bskeggs@redhat.com> Cc: "10.2 10.1" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 68f47cad)
-
Ian Romanick authored
e6967270 adds a change, and 155f98d4 reverts that change. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com>
-