Skip to content
Snippets Groups Projects
Commit ac7a4bf4 authored by Chris Wilson's avatar Chris Wilson :thinking: Committed by Adam Jackson
Browse files

os/WaitFor: Check timers on every iteration


Currently we only check timer expiry if there are no client fd (or
other input) waiting to be serviced. This makes it very easy to starve
the timers with long request queues, and so miss critical timestamps.

The timer subsystem is just another input waiting to be serviced, so
evaluate it on every loop like all the others, at the cost of calling
GetTimeInMillis() slightly more frequently. (A more invasive and likely
OS specific alternative would be to move the timer wheel to the local
equivalent of timerfd, and treat it as an input fd to the event loop
exactly equivalent to all the others, and so also serviced on every
pass. The trade-off being that the kernel timer wheel is likely more
efficiently integrated with epoll, but individual updates to each timer
would then require syscalls.)

Reviewed-by: default avatarPeter Harris <pharris@opentext.com>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 78b6f940
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment