Skip to content
Snippets Groups Projects
Commit 1e9d5533 authored by Chris Wilson's avatar Chris Wilson :thinking: Committed by Adam Jackson
Browse files

os/WaitFor: Use the simpler xorg_list_for_each_entry()


As we are not freeing elements while iterating the list of timers, we
can forgo using the safe variant, and reduce the number of pointer
dances required for the insertion sort.

Reviewed-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 6115d8b4
No related branches found
No related tags found
Loading
......@@ -295,7 +295,7 @@ OsTimerPtr
TimerSet(OsTimerPtr timer, int flags, CARD32 millis,
OsTimerCallback func, void *arg)
{
OsTimerPtr existing, tmp;
OsTimerPtr existing;
CARD32 now = GetTimeInMillis();
if (!timer) {
......@@ -328,7 +328,7 @@ TimerSet(OsTimerPtr timer, int flags, CARD32 millis,
input_lock();
/* Sort into list */
xorg_list_for_each_entry_safe(existing, tmp, &timers, list)
xorg_list_for_each_entry(existing, &timers, list)
if ((int) (existing->expires - millis) > 0)
break;
/* This even works at the end of the list -- existing->list will be timers */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment