- Nov 17, 2016
-
-
Sebastian Dröge authored
-
Sebastian Dröge authored
-
Sebastian Dröge authored
-
Vinod Kesti authored
splitmuxsink requests pad from element using pad template like "video_%u", "audio_%u" and "sink_%d". This is true for most of the muxers. But splitmuxsink not able to request pad to flvmux as flvmux has "audio" and "video" as pad templates. fix: splitmuxsink should fallback to "audio" and "video" when template not found. https://bugzilla.gnome.org/show_bug.cgi?id=774507
-
- Nov 14, 2016
-
-
Sebastian Dröge authored
The accumulator is filled by intersecting with all the pad caps, as such it must be initialized with ANY (like it is before the iteration is started) and not to EMPTY. Fixes the CAPS query always returning EMPTY caps when resyncing happened during the query, e.g. because pads were added/removed.
-
Control messages are used only in multicast mode - to detect if the destination address is not ours and possibly drop the packet. However in non-multicast modes the messages are still allocated and freed even if not used. Therefore request control messages from g_socket_receive_message() only in multicast mode. https://bugzilla.gnome.org/show_bug.cgi?id=772841
-
- Nov 04, 2016
-
-
I've seen problems where the `bytesused` field of `v4l2_buffer` would be a silly number causing the later call to: gst_memory_resize (group->mem[i], 0, group->planes[i].bytesused); to result in this error to be printed: (pulsevideo:11): GStreamer-CRITICAL **: gst_memory_resize: assertion 'size + mem->offset + offset <= mem->maxsize' failed besides causing who-knows what other problems. We make the assumption that this buffer has still been dequeued correctly so just clamp to a valid size so downstream elements won't end up in undefined behaviour. The invalid `v4l2_buffer` I saw from my capture device was: buffer = { index = 0, type = 1, bytesused = 534748928, // <- Invalid flags = 8260, // V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC | V4L2_BUF_FLAG_ERROR | V4L2_BUF_FLAG_DONE field = 01330, // <- Invalid timestamp = { tv_sec = 0, tv_usec = 0 }, timecode = { type = 0, flags = 0, frames = 0 '\000', seconds = 0 '\000', minutes = 0 '\000', hours = 0 '\000', userbits = "\000\000\000" }, sequence = 0, memory = 2, m = { offset = 3537219584, userptr = 140706665836544, // Could be nonsense, not sure planes = 0x7ff8d2d5b000, fd = -757747712 }, length = 2764800, reserved2 = 0, reserved = 0 } This is from gdb with my own annotations added. This was with gst-plugins-good 1.8.1, a Magewell XI100DUSB-HDMI video capture device and kernel 3.13 using a dodgy HDMI cable which is great at breaking HDMI capture devices. I'm using io-mode=userptr and have built gst-plugins-good without libv4l. https://bugzilla.gnome.org/show_bug.cgi?id=769765
-
Improve RFC2326 - chapter C.3 compatibility: In case just a single stream is specified in SDP and the control attribute is missing do not drop the stream but rather assume "a=control:*" https://bugzilla.gnome.org/show_bug.cgi?id=770568
-
Add a check to verify all the output buffers were empty for the session in a timout and log an error. https://bugzilla.gnome.org/show_bug.cgi?id=773269
-
Altough commits 6a16be75, 64f9d08d and 0c7e3a86 fixed some issues they introduced others. This patch fixes the leak of one macroblock for every B fragment. Macroblock structures must not be freed immediately after finding the boundaries as they are stored and used later. However the inital dummy structure (used for finding the first boundary) must be freed. CID #1212156 https://bugzilla.gnome.org/show_bug.cgi?id=773512
-
Fix leaking caps when downstream has not-fixed caps. https://bugzilla.gnome.org/show_bug.cgi?id=773515
-
Some buggy payloaders, e.g. rtph263pay, may use mode B for packets that starts with a picture (or GOB) start code although it's not allowed. Let's be nice and not drop these packets/frames. https://bugzilla.gnome.org/show_bug.cgi?id=773516
-
Sebastian Dröge authored
We would like to check later on EOS if we found a known stream type or not, to possibly post an error message. https://bugzilla.gnome.org/show_bug.cgi?id=773861
-
- Nov 02, 2016
-
-
Jan Schmidt authored
Commit 83e718 added a pad template to splitmux request pads, which means that GstElement now releases the pads on dispose, but after having removed all elements in the bin and unlinked them. Make sure we can handle cleanup in that case without throwing assertions. https://bugzilla.gnome.org/show_bug.cgi?id=773784
-
- Nov 01, 2016
-
-
Tim-Philipp Müller authored
-
Sebastian Dröge authored
-
Sebastian Dröge authored
-
Sebastian Dröge authored
-
- Oct 31, 2016
-
-
Gst struct v4l2object->extra_controls is created if user sets appropriate option but it is not freed on destruction of v4l2object. https://bugzilla.gnome.org/show_bug.cgi?id=773580
-
Sebastian Dröge authored
This reverts commit 88167641. It causes issues with the timeouts, and causes connections to be closed without actual reason. Needs further investigation. https://bugzilla.gnome.org/show_bug.cgi?id=773509
-
Sebastian Dröge authored
Otherwise we'll run into an assertion on specially crafted files. https://bugzilla.gnome.org/show_bug.cgi?id=773643
-
- Oct 27, 2016
-
-
Nirbheek Chauhan authored
These checks are done inside the meson.build files for each plugin.
-
Nirbheek Chauhan authored
Needs a Meson patch to filter out the useless -lpthread https://github.com/mesonbuild/meson/pull/962
-
Modify the caps string to allow width and height greater than 4096. There is no need to restrict it since the matroska format allows the width and height values to be up to eight bytes long. https://bugzilla.gnome.org/show_bug.cgi?id=773582
-
G_OS_WIN32 is only set when not building with cygwin, but ipi_spec_dest is missing both with and without cygwin. https://bugzilla.gnome.org/show_bug.cgi?id=773114
-
- Oct 26, 2016
-
-
souphttpsrc maintains two variables for the position: * 'request_position' is where we want to be * 'read_position' is where we are During Normal operations both are updated in sync when data arrives. A seek changes 'request_position' but not 'read_position'. When the two positions get out of sync, then a new request is send and the 'Range' header is adjusted to the current 'request_position'. Without this patch, if reading fails, then the source is destroyed. This triggers a new request, but the range remains unchanged. As a result, the old range is used and old data will be read. Changing the 'read_position' to -1 makes it explicitly different from 'request_position' and as a result the 'Range' header is updated correctly. https://bugzilla.gnome.org/show_bug.cgi?id=773509
-
Mark Nauwelaerts authored
This solves a hanging mainloop in following scenario: * connect to source * network/server drops * pipeline set to NULL (and connection to flushing as part) * pipeline set to PAUSED/PLAYING (connection to non-flushing, but not recorded) * [connecting still not possible] * pipeline set to NULL => mainloop hangs (since no actual flushing is done)
-
Jan Schmidt authored
The pacing of the overall muxing is controlled by the video GOPs arriving, so we can only handle 1 video stream, and the request pad is named accordingly. Ignore a request for a 2nd video pad if there's already an active one.
-
Jan Schmidt authored
sink the floating ref when handed a muxer or sink to use so we clearly take ownership.
-
Jan Schmidt authored
Make sure that elements are in the NULL state when removing. Fixes critical warnings when errors occur early on in starting up.
-
Jan Schmidt authored
Ensure that the ghost pad returned as a request pad has the template that was requested
-
- Oct 25, 2016
-
-
Nirbheek Chauhan authored
This reverts commit 46632694. Does not actually work. See: https://bugzilla.gnome.org/show_bug.cgi?id=773114#c31
-
- Oct 24, 2016
-
-
Nicolas Dufresne authored
This fixes issue for encoders that only sets the DTS. We assume that there was no re-ordering when that happens. https://bugzilla.gnome.org/show_bug.cgi?id=762207
-
- Oct 23, 2016
-
-
Tim-Philipp Müller authored
-
- Oct 21, 2016
-
-
- Oct 20, 2016
-
-
Tim-Philipp Müller authored
It's been broken for years, and it's unlikely it will ever be fixed for collectpads/videomixer now that there's compositor which works fine. So let's disable it, since all it does is that it creates noise that distracts from other failures. Also see the corresponding adder bug as it failed in the same way: https://bugzilla.gnome.org/show_bug.cgi?id=708891
-