Skip to content
Snippets Groups Projects
  1. Sep 08, 2021
  2. Sep 07, 2021
  3. Sep 06, 2021
  4. Sep 02, 2021
  5. Aug 28, 2021
  6. Aug 24, 2021
  7. Aug 23, 2021
  8. Aug 15, 2021
  9. Jul 08, 2021
  10. Jun 11, 2021
  11. Jun 03, 2021
  12. Jun 02, 2021
    • Tim-Philipp Müller's avatar
      rtpjpegpay: fix image corruption when compiled with MSVC on Windows · 41c100bc
      Tim-Philipp Müller authored
      On Windows with MSVC, jpeg_header_size would end up 2 bytes larger
      than it should be. This then leads to the first 2 bytes of the
      actual jpeg image data to be dropped, because we think those
      belong to the header, which results in an undecodable image when
      reconstructed in the depayloader.
      
      What happens is that when the compiler evaluates
      
        jpeg_header_size = mem.offset + read_u16_and_inc_offset_by_2(&mem);
      
      it actually uses the mem.offset value after it has been increased
      by the function call on the right hand size of the equation.
      
      From section 6.5 of the C99 spec:
      
        3. The grouping of operators and operands is indicated by the syntax [74].
           Except as specified later (for the function-call (), &&, ||, ?:, and
           comma operators), the order of evaluation of subexpressions and the
           order in which side effects take place are both unspecified.
      
      Fixes gstreamer/gst-plugins-good#889
      
      Part-of: <gstreamer/gst-plugins-good!1003>
      41c100bc
  13. Jun 01, 2021
  14. May 14, 2021
  15. Apr 30, 2021
    • Jan Schmidt's avatar
      qtmux: Make sure to write 64-bit STCO table when needed. · 218f924b
      Jan Schmidt authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      qtmux attempts to choose between writing a 32-bit stco chunk offset table
      when it can, but switch to a 64-bit co64 table when file offsets go over
      4GB.
      
      This patch fixes a problem where the atom handling code was checking
      mdat-relative offsets instead of the final file offset (computed by
      adding the mdat position plus the mdat-relative offset) - leading to
      problems where files with a size between 4GB and 4GB+offset-of-the-mdat
      would write incorrect STCO tables with some samples having truncated
      32-bit offsets.
      
      Smaller files write STCO correctly, larger files would switch to
      co64 and also output correctly.
      
      Part-of: <!972>
      218f924b
    • Qi Hou's avatar
      v4l2object: Add interlace-mode back to caps for camera · ea1a6c47
      Qi Hou authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      skip_try_fmt_probes is set to TRUE for v4l2src to skip interlace-mode and
      colorimetry when probe caps. gst_v4l2_object_set_format_full() will add
      colorimetry back to caps when iterating over the negotiated caps. There is
      one case that v4l2src is first in preview state then starts recording.
      v4l2src caps will change with an additional interlace-mode structure after
      renegotiation, then v4l2src needs to reset. But this camera driver can't
      orphan buffer pool, it causes require buffer failed as streaming is still
      in active state.
      
      To fix this, also need to add interlace-mode back to caps for camera to
      avoid reset.
      
      Part-of: <!971>
      ea1a6c47
  16. Apr 22, 2021
  17. Apr 20, 2021
  18. Apr 14, 2021
  19. Apr 13, 2021
  20. Apr 01, 2021
    • Qi Hou's avatar
      v4l2object: Use default colorimetry if that in caps is unknown · d2b82cd8
      Qi Hou authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Some streams have unknown colorimetry in caps, but v4l2object sets
      default values for each primaries. It will cause check colorimetry
      fail when do gst_v4l2_video_colorimetry_matches().
      
      To fix this, need to keep the unknown colorimetry in caps same as
      the default value set by v4l2object.
      
      Part-of: <!930>
      d2b82cd8
  21. Mar 25, 2021
Loading