Skip to content

Only build flutter-engine for enabled configurations

Joel Winarske requested to merge github/fork/blindmatrix/kirkstone into kirkstone

Created by: blindmatrix

Two changes in this PR.

  • Only build and install the flutter-engine for the enabled modes by querying the processed PACKAGECONFIG.
  • Only build apps (inherit flutter-app) for the enabled (installed) engine modes (by looking for installed engine_sdk.zip).

The second commit ("Only build flutter-apps for actually installed modes") is required to fix leftover empty directories in the sysroot.

You could also have determined the enabled modes like this (for flutter-engine)

     FLUTTER_RUNTIME_MODES="\
        ${@bb.utils.contains('PACKAGECONFIG', 'debug', 'debug', '', d)} \
        ${@bb.utils.contains('PACKAGECONFIG', 'profile', 'profile', '', d)} \
        ${@bb.utils.contains('PACKAGECONFIG', 'release', 'release', '', d)} \
        ${@bb.utils.contains('PACKAGECONFIG', 'jit_release', 'jit_release', '', d)}"

but since the old code preferred to fetch the mode names from what's enabled via --runtime-mode I opted to look at the parsed config instead.

Merge request reports