Skip to content
Snippets Groups Projects
  1. Jun 25, 2019
  2. Jun 21, 2019
  3. Jun 20, 2019
  4. Jun 19, 2019
  5. Jun 18, 2019
  6. Jun 17, 2019
  7. Jun 14, 2019
  8. Jun 11, 2019
  9. Jun 09, 2019
    • Kenneth Graunke's avatar
      egl/x11: calloc dri2_surf so it's properly zeroed · 84bd3612
      Kenneth Graunke authored and Juan A. Suárez's avatar Juan A. Suárez committed
      
      Commit 2282ec0a refactored drawable creation across various platforms
      into a new dri2_create_drawable helper function.
      
      The GBM code in platform_drm.c code passed in dri2_surf->gbm_surf as the
      loaderPrivate, while most other backends passed in dri2_surf directly.
      
      To try and handle this, the patch checked if dri2_surf->gbm_surf was
      non-NULL, and if so, presumed that the caller is the DRM platform and
      we should use the dri2_surf->gbm_surf pointer.
      
      This worked for most platforms, which calloc their dri2_surf structure,
      zeroing the data.  Unfortunately, platform_x11.c used malloc, leaving
      most of the dri2_surf as garbage.  In particular, dri2_surf->gbm_surf
      was often non-NULL, causing dri2_create_drawable to try and use it,
      passing a garbage pointer to the createNewDrawable hook, usually leading
      to a SIGBUS or SIGSEGV when trying to dereference that bad pointer.
      
      Since most callers calloc the data, make platform_x11.c follow suit.
      
      Fixes crashes with i915_dri.so when running dEQP-GLES2.
      
      Reviewed-by: default avatarMathias Fröhlich <Mathias.Froehlich@web.de>
      Reviewed-by: default avatarTapani Pälli <tapani.palli@intel.com>
      (cherry picked from commit 4e3297f7)
      84bd3612
    • Eric Engestrom's avatar
      util/os_file: actually return the error read() gave us · c025240f
      Eric Engestrom authored and Juan A. Suárez's avatar Juan A. Suárez committed
      
      Fixes: 31696470 "util: add os_read_file() helper"
      Signed-off-by: default avatarEric Engestrom <eric.engestrom@intel.com>
      Reviewed-by: default avatarEric Anholt <eric@anholt.net>
      (cherry picked from commit 7e35f20d)
      c025240f
    • Rob Clark's avatar
      freedreno/a6xx: fix hangs with newer sqe fw · 3301eeee
      Rob Clark authored and Juan A. Suárez's avatar Juan A. Suárez committed
      
      With the newer (v1.76) fw, we were getting hangs (compared to older
      v1.66 fw).  Re-work the GMEM code to structure things a bit closer to
      the blob.  This moves some PKT7 packets from IB2 to IB1, which I think
      is what was confusing SQE and causing it to get stuck in an infinite
      loop.  But in general structuring things at least closer to the same way
      blob does makes it easier to compare cmdstream.
      
      Note: this is a bit on the large side for what I'd normally consider for
      stable.. but right now it is looking  like it is the newer fw that is
      headed for linux-firmware.  This should defn have some soak time on
      master, but probably a good idea for this patch to end up in distro mesa
      builds by the time a630_sqe.fw hits linux-firmware.
      
      Cc: mesa-stable@lists.freedesktop.org
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      Reviewed-by: default avatarKristian H. Kristensen <hoegsberg@google.com>
      (cherry picked from commit 958f6ffb)
      3301eeee
Loading