Skip to content
  • Adam Jackson's avatar
    render: Break PICT_a4 · 436fd7e8
    Adam Jackson authored and Adam Jackson's avatar Adam Jackson committed
    The Render protocol requires this format, but it is wrong to do so. We
    are not aware of any hardware with a real 4bpp implementation of this
    format. Some GL hardware may have GL_LUMINANCE4_ALPHA4_EXT, and may also
    be able to wire L to 1, but that would win you none of memory, quality,
    or (likely) performance over A8. Any attempt to use this format is
    therefore likely a (painful) software fallback.
    
    Pleasantly (and given the above, unsurprisingly) it seems to be unused
    in the wild. None of the major toolkits will try to use it, and
    rendercheck does not in fact validate that all of the "standard" picture
    formats exist.
    
    Drop the explicit A4 setup from picture format initialization. Note that
    the DDXes are not changed and still expose a depth-4 pixmap format, but
    we only add picture formats for True/DirectColor-credible depths (i.e.
    depth >= 15).
    
    Implements: xorg/proto/xorgproto!1
    
    
    Signed-off-by: default avatarAdam Jackson <ajax@redhat.com>
    436fd7e8