Skip to content
Snippets Groups Projects
Commit ee60e626 authored by Filip Pokryvka's avatar Filip Pokryvka :cartwheel_tone1: Committed by Jakub Kicinski
Browse files

netdevsim: don't overwrite read only ethtool parms


Ethtool ring feature has _max_pending attributes read-only.
Set only read-write attributes in nsim_set_ringparam.

This patch is useful, if netdevsim device is set-up using NetworkManager,
because NetworkManager sends 0 as MAX values, as it is pointless to
retrieve them in extra call, because they should be read-only. Then,
the device is left in incosistent state (value > MAX).

Fixes: a7fc6db0 ("netdevsim: support ethtool ring and coalesce settings")
Signed-off-by: default avatarFilip Pokryvka <fpokryvk@redhat.com>
Link: https://lore.kernel.org/r/20211210175032.411872-1-fpokryvk@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 94f2a444
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment