Skip to content
Snippets Groups Projects
Commit d179f99a authored by Shuah Khan (Samsung OSG)'s avatar Shuah Khan (Samsung OSG) Committed by Greg Kroah-Hartman
Browse files

usbip: usbip_detach: Fix memory, udev context and udev leak


detach_port() fails to call usbip_vhci_driver_close() from its error
path after usbip_vhci_detach_device() returns failure, leaking memory
allocated in usbip_vhci_driver_open() and holding udev_context and udev
references. Fix it to call usbip_vhci_driver_close().

Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent edf38004
No related branches found
No related tags found
No related merge requests found
...@@ -43,7 +43,7 @@ void usbip_detach_usage(void) ...@@ -43,7 +43,7 @@ void usbip_detach_usage(void)
static int detach_port(char *port) static int detach_port(char *port)
{ {
int ret; int ret = 0;
uint8_t portnum; uint8_t portnum;
char path[PATH_MAX+1]; char path[PATH_MAX+1];
...@@ -73,9 +73,12 @@ static int detach_port(char *port) ...@@ -73,9 +73,12 @@ static int detach_port(char *port)
} }
ret = usbip_vhci_detach_device(portnum); ret = usbip_vhci_detach_device(portnum);
if (ret < 0) if (ret < 0) {
return -1; ret = -1;
goto call_driver_close;
}
call_driver_close:
usbip_vhci_driver_close(); usbip_vhci_driver_close();
return ret; return ret;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment