-
- Downloads
Add a reference to ucounts for each cred
For RLIMIT_NPROC and some other rlimits the user_struct that holds the global limit is kept alive for the lifetime of a process by keeping it in struct cred. Adding a pointer to ucounts in the struct cred will allow to track RLIMIT_NPROC not only for user in the system, but for user in the user_namespace. Updating ucounts may require memory allocation which may fail. So, we cannot change cred.ucounts in the commit_creds() because this function cannot fail and it should always return 0. For this reason, we modify cred.ucounts before calling the commit_creds(). Changelog v6: * Fix null-ptr-deref in is_ucounts_overlimit() detected by trinity. This error was caused by the fact that cred_alloc_blank() left the ucounts pointer empty. Reported-by:kernel test robot <oliver.sang@intel.com> Signed-off-by:
Alexey Gladkov <legion@kernel.org> Link: https://lkml.kernel.org/r/b37aaef28d8b9b0d757e07ba6dd27281bbe39259.1619094428.git.legion@kernel.org Signed-off-by:
Eric W. Biederman <ebiederm@xmission.com>
Showing
- fs/exec.c 4 additions, 0 deletionsfs/exec.c
- include/linux/cred.h 2 additions, 0 deletionsinclude/linux/cred.h
- include/linux/user_namespace.h 4 additions, 0 deletionsinclude/linux/user_namespace.h
- kernel/cred.c 40 additions, 0 deletionskernel/cred.c
- kernel/fork.c 6 additions, 0 deletionskernel/fork.c
- kernel/sys.c 12 additions, 0 deletionskernel/sys.c
- kernel/ucount.c 37 additions, 3 deletionskernel/ucount.c
- kernel/user_namespace.c 3 additions, 0 deletionskernel/user_namespace.c
Loading
Please register or sign in to comment