- Dec 17, 2021
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
This function is called on load/store_input/output. It makes no sense for it to get a SYSTEM_VALUE enum. This only doesn't explode because SYSTEM_VALUE_PRIMITIVE_ID happens to be below VARYING_SLOT_VAR0 so it doesn't interact with any actual varyings. The next commit is going to add another system value which will push SYSTEM_VALUE_PRIMITIVE_ID up by one so it will equal VARYING_SLOT_VAR0 and then the first FS input will always get smashed to flat which isn't what we want. Fixes: b59bb9c0 ("radeonsi: force flat for PrimID early in si_nir_scan_shader") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!14198> (cherry picked from commit 732b234d)
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: b996fa8e ("anv: implement VK_KHR_synchronization2") Closes: mesa/mesa#5744 Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!14237> (cherry picked from commit cdf10145)
-
src/intel/tools/intel_noop_drm_shim.c:459:36: warning: initialized field overwritten [-Woverride-init] 459 | [DRM_I915_GEM_EXECBUFFER2_WR] = i915_ioctl_noop, | ^~~~~~~~~~~~~~~ Fixes: 0f4f1d70 ("intel: add stub_gpu tool") Reviewed-by:Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!14218> (cherry picked from commit 2dc7c24b)
-
Fixes: 22673a98 ("meson: Check arguments before adding") Reviewed-by:
-
Fixes: c7fc44f9 ("nir/from_ssa: Respect and populate divergence information") Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Reviewed-by:
-
I copied stuff from ac_gpu_info.c until there were no Sienna Cichild or Polaris10 fossil-db changes between real hardware and RADV_FORCE_FAMILY. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!14126> (cherry picked from commit 451e6c1b)
-
Fixes: 55be94dc ("iris/bufmgr: Add new set of buckets for local memory.") Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org>
Part-of: <mesa/mesa!14012>
(cherry picked from commit f93892c5) -
Insert a flush after a depth decompression pass if the texture was fast cleared. This fixes a corruption which seems to only affect gfx10.3 chips. Ideally we should also clear tex->need_flush_after_depth_decompression after a flush but there's no easy way for this so this commit will introduce extra flushes. Cc: mesa-stable Part-of: <mesa/mesa!14089> (cherry picked from commit 573d6451)
-
Currently V3DV_HAS_SURFACE is always defined. There is no WSI for Android in mesa3d, therefore WSI related extensions should not be exposed. 1. Define V3DV_HAS_SURFACE only for platforms which has WSI implemented. 2. Rename V3DV_HAS_SURFACE -> V3DV_USE_WSI_PLATFORM to align naming with other platforms. Fixes dEQP-VK.wsi.android.surface#query_protected_capabilities Fixes: 79e44514 ("v3dv: move extensions table to v3dv_device") Signed-off-by:
Roman Stratiienko <roman.o.stratiienko@globallogic.com> Reviewed-by:
Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!14144> (cherry picked from commit fcfc4ddf)
-
This might have led to a leak in firefox/webrender/webgl scenarios Reviewed-by:
-
(v1) Changelog: -Ddri-drivers option is added in MESON_GEN_NINJA $(foreach ) cycle copies *_dri.so files to /vendor/lib{64}/dri/ (v2) Changelog Remove unwanted Symlinks created for classic dri drivers Update the comments describing each step Rename .symlinks.timestamp to .targets.timestamp Squash all the changes in one commit to facilitate picking in mesa stable HowTo: BoardConfig.mk: BOARD_MESA3D_CLASSIC_DRIVERS defines the list of classic dri drivers example: BOARD_MESA3D_CLASSIC_DRIVERS := i965 Fixes: 8621bd8d ("android: Add scripts to build using meson") Cc: "21.3" "21.2" mesa-stable Reviewed-by:Roman Stratiienko <r.stratiienko@gmail.com> Part-of: <!13973>
-
We were setting anv_pipeline::sample_shading_enable based on sampleShadingEnable without looking at minSampleShading. We would then pass this value into nir_lower_wpos_center which would add sample_pos to frag_coord. Then the back-end compiler picks up on the existence of sample_pos and forces persample dispatch. This leads to doing per-sample dispatch whenever sampleShadingEnable = VK_TRUE regardless of the value of minSampleShading. This is almost certainly costing us perf somewhere. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
-
Fixes: f3630548 ("crocus: initial gallium driver for Intel gfx 4-7") Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!14141> (cherry picked from commit 4175ed50)
-
Fixes crash in Oblivion, Skyrim, Crysis running through DXVK on 32b systems. Closes: mesa/mesa#5723 Fixes: 937dd764 "turnip: Implement VK_KHR_performance_query" Signed-off-by:
Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <mesa/mesa!14148> (cherry picked from commit c82d7e36)
-
According to the Vulkan spec chapter 9.25 Helper Invocations, quad group operations have to be executed by helper invocations. This commit cleans up the code for quad group instructions by unifying the code path of quad broadcast with the others, and then calling emit_wqm just once at the end. Fixes: 93c8ebfa Closes: mesa/mesa#5570 Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
-
Previously a predicated BREAK that appeared immediately before the WHILE would get merged into the WHILE. This doesn't work if other flow control (e.g., a CONT) can transfer directly to the WHILE. On Intel platforms, this fixes the CTS test dEQP-VK.graphicsfuzz.stable-binarysearch-tree-nested-if-and-conditional. No shader-db changes on any Intel platform. When this commit was first created (over a month before it is going to land), there were some regressions that were prevented by other commits in MR !13095. That does not appear to be the case now, so I don't know what changed. Basically, the treatment of discard as a combination of demote and terminate causes additional continues in some loops, and those continues trigger this bug. The other commits from that MR prevent those continues from being generated in the first place. All Intel platforms had simlar fossil-db results. (Ice Lake shown) Instructions in all programs: 144419989 -> 144419995 (+0.0%) SENDs in all programs: 6947332 -> 6947332 (+0.0%) Loops in all programs: 38277 -> 38277 (+0.0%) Spills in all programs: 204075 -> 204075 (+0.0%) Fills in all programs: 319480 -> 319480 (+0.0%) A few shaders in Doom 2016 were hurt by one instruction each. It seems likely that these shaders would have experienced at least some mis-rendering. Closes: #4213 Fixes: d13bcdb3 ("i965/fs: Extend predicated break pass to predicate WHILE.") Reviewed-by:
-
When mesa3d is built without VK_USE_PLATFORM_DISPLAY_KHR definition, dEQP test fails: dEQP : Test case 'dEQP-VK.info.instance_extensions'.. dEQP : Fail (Extension VK_KHR_get_display_properties2 is missing dependency: VK_KHR_display) dEQP : DONE! Enable KHR_get_display_properties2 only if VK_USE_PLATFORM_DISPLAY_KHR is enabled. Fixes: f884c2e3 ("v3dv: implement VK_KHR_get_display_properties2") Signed-off-by: -
Older drivers will not expect any flags from the GBM front-end when modifiers are in use, and will likely fail the allocation or handle them incorrectly as a result. Only specify usage flags when allocating from a backend with an ABI >= 1, as that's the ABI version that added support for specifying usage flags along with modifiers. Fixes: ad50b47a ("gbm: assume USE_SCANOUT in create_with_modifiers") Closes: mesa/mesa#5709 Signed-off-by:
James Jones <jajones@nvidia.com> Reviewed-by:
Simon Ser <contact@emersion.fr> Tested-by:
Olivier Fourdan <ofourdan@redhat.com> Part-of: <mesa/mesa!14049> (cherry picked from commit c2550d1b)
-
This virtual instruction is translated into multiple half float physical instructions, even though its destination is typically of integer type, which prevents the software scoreboard pass from inferring the correct execution pipeline for the virtual instruction on XeHP+ platforms. Teach the SWSB lowering pass about this inconsistency between the IR and physical instruction types. Fixes among other tests: dEQP-GLES31.functional.shaders.builtin_functions.pack_unpack.packhalf2x16_compute Fixes: d4537770 ("intel/fs: Add helper functions inferring sync and exec pipeline of an instruction.") Closes: mesa/mesa#5685 Reported-by:
Tapani Pälli <tapani.palli@intel.com> Tested-by:
Matt Turner <mattst88@gmail.com> Reviewed-by:
Caio Oliveira <caio.oliveira@intel.com> Part-of: <mesa/mesa!14002> (cherry picked from commit de55fd35)
-
Will fix a compiler error when we #include the Valhall disassembler header from pandecode. Fixes: 688827f3 ("pan/va: Add disassembler generator") Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!14063> (cherry picked from commit 745d7db7)
-
ASAN found a leak: ``` Direct leak of 1440 byte(s) in 10 object(s) allocated from: #0 0x4a9a92 in calloc (build-Monado-CMake/src/xrt/targets/service/monado-service+0x4a9a92) #1 0x7fdf82afed06 in drmDeviceAlloc build-drm/../drm/xf86drm.c:3933:14 #2 0x7fdf82b00203 in drmProcessPciDevice build-drm/../drm/xf86drm.c:3965:11 #3 0x7fdf82b00203 in process_device build-drm/../drm/xf86drm.c:4359:16 #4 0x7fdf82b0485e in drmGetDevice2 build-drm/../drm/xf86drm.c:4528:15 #5 0x7fdf70751113 in device_select_find_xcb_pci_default ../src/vulkan/device-select-layer/device_select_x11.c:95:13 #6 0x7fdf70751113 in get_default_device ../src/vulkan/device-select-layer/device_select_layer.c:395:21 #7 0x7fdf70751113 in device_select_EnumeratePhysicalDevices ../src/vulkan/device-select-layer/device_select_layer.c:456:33 ``` Cc: mesa-stable Reviewed-by:Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
-
Signed-off-by:
-
Signed-off-by:
-
From VK_KHR_synchronization2: "Image memory barriers that do not perform an image layout transition can be specified by setting oldLayout equal to newLayout. E.g. the old and new layout can both be set to VK_IMAGE_LAYOUT_UNDEFINED, without discarding data in the image." v2: make assert more readable (Lionel Landwerlin) Cc: mesa-stable Signed-off-by: -
Found while running valgrind : ==3583454== Invalid read of size 4 ==3583454== at 0xF48336: glsl_get_struct_field_offset (nir_types.cpp:84) ==3583454== by 0xC7CD0D: opt_replace_struct_wrapper_cast (nir_deref.c:1068) ==3583454== by 0xC7CDD9: opt_deref_cast (nir_deref.c:1087) ==3583454== by 0xC7DD8E: nir_opt_deref_impl (nir_deref.c:1369) ==3583454== by 0xC7DF4E: nir_opt_deref (nir_deref.c:1428) ==3583454== by 0xA63F3C: brw_kernel_from_spirv (brw_kernel.c:325) ==3583454== by 0xA3BC2C: main (intel_clc.c:481) ==3583454== Address 0xe4f7e88 is 24 bytes after a block of size 48 in arena "client" Signed-off-by:
-
Eric Engestrom authored
-
- Dec 01, 2021
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
libLLVM for Android is built without RTTI, but after commit ad862674 mesa inherits meson default RTTI enabled state. cpp_rtti=false is added to meson options in android/mesa3d_cross.mk (v2) Add Fixes tag and use spaces instead of tabs for aligning the trailing \ Signed-off-by:
Mauro Rossi <issor.oruam@gmail.com> Fixes: ad862674 ("meson: Don't override built-in cpp_rtti option, error if it's invalid") Cc: "21.3" "21.2" mesa-stable Reviewed-by:
Marijn Suijten <marijn.suijten@somainline.org> Part-of: <mesa/mesa!13901> (cherry picked from commit 1ba231fb)
-
Signed-off-by:
-
If there is holes, eg. the application firsts set vertex attributes 0 and 1, then vertex attributes 0 and 7, the format of vertex attribute 1 is still the previous one, while it should be FORMAT_INVALID to avoid a GPU hang. This fixes a GPU hang with Yuzu. Closes: mesa/mesa#5627 Cc: 21.3 mesa-stable Signed-off-by:
-
In some non-trivial cases (the amber script file in the merge request description) phi instruction has more than 32 elements in predecessors tree and that isn't recursion, just large tree. In that case, phis not fully converted into a register or mov, but successfully removed. The fix removes the counter and adds container of visited blocks. Closes: mesa/mesa#3690 Cc: mesa-stable Signed-off-by:
Mykhailo Skorokhodov <mykhailo.skorokhodov@globallogic.com> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!13710> (cherry picked from commit 391569e9)
-
If there is a halt or return instruction right before a loop with a single continue, we would have taken the fast path intended for loops without continues. Signed-off-by:
-
Otherwise it fails to open a file. Fixes: 9660427a ("lima: Print usage if --help is any of the arguments.") Reviewed-by:
Andreas Baierl <ichgeh@imkreisrum.de> Signed-off-by:
Vasily Khoruzhick <anarsoul@gmail.com> Part-of: <mesa/mesa!13968> (cherry picked from commit 711a4ccd)
-
The game calls vkGetSemaphoreCounterValue() with an invalid semaphore handle and it crashes. This is an invalid Vulkan usage and it should be fixed in the game. I reported the issue to the developers. Workaround this temporarily (hopefully) by ignoring vkGetSemaphoreCounterValue() if the semaphore is NULL from an internal RADV layer. Cc: 21.3 mesa-stable Closes: mesa/mesa#5119 Signed-off-by:
-
The lima board farm will be unavailable for a few days, so disable it to avoid CI failures. Signed-off-by:
Erico Nunes <nunes.erico@gmail.com> Reviewed-by:
-
When cloning a chunk of tracepoints, we cannot just copy the elements of the traces[] array. We also need the payloads associated with those. This change introduces a new u_trace_payloaf_buf object that is refcounted so that we can easily import traces[] elements and their payloads from one utrace to another. v2: use u_vector (Danylo) v3: Delete outdate comment (Danylo) Fix assert (Danylo) Signed-off-by: -
spirv_to_nir sometimes wraps derefs in vec2 or mov instructions as part of its texture handling. These get in the way of nir_rematerialize_derefs_in_use_blocks_impl. Running copy propagation should get rid of the extra move instructions and get us back to intact deref chains for everything except variable pointer use-cases. fossil-db (Sienna Cichlid): Totals from 6 (0.00% of 134572) affected shaders: CodeSize: 92656 -> 93088 (+0.47%) Instrs: 17060 -> 17138 (+0.46%) Latency: 224408 -> 227539 (+1.40%) InvThroughput: 37402 -> 37924 (+1.40%) VClause: 408 -> 402 (-1.47%) Copies: 1065 -> 1107 (+3.94%) Signed-off-by:
-
