Skip to content

Fix OrcTargetPowerPCFlags enum typedef

Pablo Marcos Oltra requested to merge pamarcos/orc:fix_build_macos into master

A recent commit broke the build for macOS because of duplicated symbols:

libtool: link: clang  -o .libs/libgstaudioresample.so -bundle  .libs/libgstaudioresample_la-gstaudioresample.o .libs/libgstaudioresample_la-speex_resampler_int.o .libs/libgstaudioresample_la-speex_resampler_float.o .libs/libgstaudioresample_la-speex_resampler_double.o   -L/opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libgstbase-0.10.dylib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libgstreamer-0.10.dylib -ldl /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libgobject-2.0.dylib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libffi.dylib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libgmodule-2.0.dylib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libgthread-2.0.dylib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libglib-2.0.dylib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libintl.dylib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libxml2.dylib -lpthread /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/libz.dylib -liconv -lm /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/liborc-test-0.4.dylib /opt/fluendo-sdk-release_darwin_darwin_x86_64/dist/darwin_x86_64/lib/liborc-0.4.dylib  -g -msse -msse2 -msse4.1 -g -O2 -arch x86_64 -m64 -mmacosx-version-min=10.10 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -Wl,-headerpad_max_install_names -arch x86_64 -m64 -Wl,-arch -Wl,x86_64 -mmacosx-version-min=10.10 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk   -Wl,-exported_symbols_list,.libs/libgstaudioresample-symbols.expsym
duplicate symbol _OrcTargetPowerPCFlags in:
    .libs/libgstaudioresample_la-gstaudioresample.o
    .libs/libgstaudioresample_la-speex_resampler_int.o
duplicate symbol _OrcTargetPowerPCFlags in:
    .libs/libgstaudioresample_la-gstaudioresample.o
    .libs/libgstaudioresample_la-speex_resampler_float.o
duplicate symbol _OrcTargetPowerPCFlags in:
    .libs/libgstaudioresample_la-gstaudioresample.o
    .libs/libgstaudioresample_la-speex_resampler_double.o
ld: 3 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

We could either use a typedef or not name the enum at all since it's not used anyways. In any case, a good addition would be to add a macOS build to the CI :)

Merge request reports