Skip to content

avx: Fix ldreslinl and add convsssql

amyspark requested to merge amyspark/orc:amyspark/gstreamer into main

Hey all,

@slomo let me know of a couple outstanding errors with the GStreamer test suite post !111 (merged):

  • gst-plugins-base:elements_overlaycomposition was failing with a pixel compare mismatch
  • gst-plugins-base:elements_volume was failing because of the lack of convsssql for x86

This MR fixes both. In the former, I misunderstood the swizzling step to be channel-wise whereas it was meant to interleave both the original and the interpolated pixel. For the latter, I had to break ABI again 😔 in order to implement 4-operand variable blends as recommended by Clang:

https://godbolt.org/z/8qxh3v9ds

I took the chance to get rid of some redundancies we'd talked about when reviewing the AVX backend, with this MR there should no longer be the need to check for more opcode types within the AVX2 codegen.

Merge request reports