Skip to content

Fix subprocess for compatibility on Python versions < 3.7

Seungmin Kim requested to merge (removed):meson-4.4 into meson-4.4

For some reason, the script https://gitlab.freedesktop.org/gstreamer/meson-ports/ffmpeg/-/blob/meson-4.4/compat/windows/makedef.py executes while building GStreamer in Ubuntu 18.04. Because the default Python version is 3.6 in Ubuntu 18.04, capture_output=True, which is only available on Python 3.7+, fails and the build process breaks and GStreamer build stops in the default Python version of Ubuntu 18.04.

This PR changes that to stdout=subprocess.PIPE, stderr=subprocess.PIPE which does the same thing as capture_output=True for Python 3.6 and under.

Closes #30 (closed).

While I understand Python 3.6 is on course to be deprecated, this maintains the last bits of support for the remaining times. There is another five months left for Ubuntu 18.04.

Edited by Seungmin Kim

Merge request reports