Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.1k
    • Issues 1.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 497
    • Merge requests 497
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gstreamergstreamer
  • Merge requests
  • !915

Revert "h264parser: Expose framerate even if fixed_frame_rate flag isn't set"

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Mathieu Duponchelle requested to merge meh/gstreamer:gst-plugins-bad-h264parser-fix-non-fixed-framerate into main Sep 24, 2021
  • Overview 19
  • Commits 1
  • Pipelines 2
  • Changes 1

Copied from https://gitlab.freedesktop.org//gstreamer/gst-plugins-bad/-/merge_requests/1215

This reverts commit 43006110.

The assumption was that:

There is nothing in the spec that state that framerate is not valid in that case.

However, when looking at the speci (section E.2.1), it clearly states that:

fixed_frame_rate_flag equal to 1 indicates that the temporal distance between the HRD output times of any two consecutive pictures in output order is constrained as follows. fixed_frame_rate_flag equal to 0 indicates that no such constraints apply to the temporal distance between the HRD output times of any two consecutive pictures in output order. When fixed_frame_rate_flag is not present, it shall be inferred to be equal to 0.

Moreover, the process for calculating DeltaTfiDivisor is clearly conditioned to this flag being set to 1:

When fixed_frame_rate_flag is equal to 1 for a coded video sequence containing picture n [..]

There is no provision for the value of DeltaTfiDivisor when fixed_frame_rate_flag is 0.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gst-plugins-bad-h264parser-fix-non-fixed-framerate