Skip to content

rtspsrc: Various control URL handling fixes

Sebastian Dröge requested to merge slomo/gstreamer:rtspsrc-setup-workaround-absolute-uri into main 
commit 8d064378c3fae6dfc80f54efc60b0353e154354e
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon May 27 14:14:24 2024 +0300

    rtspsrc: Only update from the Content-Base header in the initial OPTION / DESCRIBE response
    
    Some servers send a new content base in the SETUP response, which is
    just the non-aggregate control URL of the individual streams.
    
    See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3563

commit a42487bd3b68c3b557c35020ac7f8d7cdf7b0a56
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sun May 26 14:03:11 2024 +0300

    rtspsrc: Handle the case of `*` as session-wide control URL from the SDP
    
    Just like the comment above says this is supposed to indicate that the
    same URL should be used as for the connection so far. If encountering
    this case simply do nothing.

commit cf653f5f2854351d8fcc94d7ee6b9db0c574582f
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sun May 26 14:02:12 2024 +0300

    rtspsrc: Also handle `rtsps://` and similar URLs as absolute in other places
    
    Previously a direct comparison with `rtsp://` was performed, which
    didn't catch cases like `rtsps://`.
    
    Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3563

commit b682571cc676ed6d5fb8c3c2635a5fa19d5d0cbe
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sun May 26 13:00:02 2024 +0300

    rtspsrc: Don't try the SETUP workaround for broken servers with absolute control URIs
    
    Previously only control URIs that started with "rtsp://" were ignored
    but it makes more sense to ignore all absolute URIs.
    
    gst_uri_is_valid() conveniently checks for exactly that.
    
    See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3563
Edited by Sebastian Dröge

Merge request reports