Skip to content

gstinfo: colorize PIDs in log messages

Chris White requested to merge cxw42/gstreamer:issue624 into master

The PIDs on log lines were supposed to be colorized before, but the escape sequence was incorrect. With this change, the code uses the correct sequence to colorize those PIDs. E.g., instead of \033[334m (incorrect), use \033[34m (correct).

This makes the log messages easier to read. It also reduces the chance that a buggy terminal will choke on the invalid escape sequence.

Fixes #624 (closed).

This is my first GStreamer MR, so please don't hesitate to let me know if I need to change something! I have reviewed the "Contributing to GStreamer" section of the documentation, but that doesn't mean I got everything right :) . For example, I can move the ! ! fixes to a separate commit if necessary. Thanks for considering this MR!

Edited by Chris White

Merge request reports