Skip to content
Snippets Groups Projects

bufferlist: get() is not actually nullable in its return value

Merged Sebastian Dröge requested to merge slomo/gstreamer:buffer-list-get-nullable into main
All threads resolved!

Passing an out of bounds index is the only way to get a NULL buffer but this causes an assertion so is not to be considered for the annotations.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Sebastian Dröge

      since it can still return NULL when g_return_val_if_fail() triggers, but not with valid usage, are there rules how bindings are supposed to handle that? We ignore the invalid usage scenario and it's up to bindings to handle that gracefully but if not that's ok too because at some point everything's tainted and might crash at any point anyway?

  • Sebastian Dröge resolved all threads

    resolved all threads

  • added 1 commit

    • 27e1cfd1 - bufferlist: get() is not actually nullable in its return value

    Compare with previous version

  • added 17 commits

    • 27e1cfd1...0f8b599d - 16 commits from branch gstreamer:main
    • 0a0c9672 - bufferlist: get() is not actually nullable in its return value

    Compare with previous version

  • assigned to @slomo and unassigned @gstreamer-merge-bot

  • added 1 commit

    • 65f9a304 - bufferlist: get() is not actually nullable in its return value

    Compare with previous version

  • assigned to @gstreamer-merge-bot and unassigned @slomo

  • added 17 commits

    • 65f9a304...0f8b599d - 16 commits from branch gstreamer:main
    • 1a8e7aa9 - bufferlist: get() is not actually nullable in its return value

    Compare with previous version

  • changed milestone to %1.25.1

  • Please register or sign in to reply
    Loading