Skip to content

flacparse: fix buffer overflow

Sergey Krivohatskiy requested to merge SergeyKrivohatskiy/gstreamer:fix-buffer-overflow-in-gst-flac-parse into main

Fixed gst_flac_parse_frame_is_valid not respecting buffer size and reading bytes after buffer end in some cases.

The bug is rare as it requires calling this function in the end of the buffer and a 2 bytes with a specific content (looking like frame start).

I faced the bug when experimenting with source pushing random small buffers into pipeline, reading a .flac file.

See commit comments for details.

Merge request reports