Skip to content

playbin3: Handle combiner update in case of errors

Edward Hervey requested to merge bilboed/gstreamer:playbin3-combiner-assertion into main

The assertion that was present before is a bit too harsh, since there is now a (understandable) use-case where this could happen.

In gapless use-case, with two files containing the same type (ex:audio). The first one does expose a collection with an audio stream, but decoding fails (for whatever reason).

That would cause us to have configured a audio combiner, which was never used (i.e. not active).

Then the second file plays and we (wrongly) assume it should be activated ... whereas the combiner was indeed present.

Demote the assertion to a warning and properly handle it

Fixes #3389 (closed)

Merge request reports