Skip to content

tsmux: do not write start_unit_indicator twice

Yury Shatz requested to merge jurijs.satcs/gstreamer:tsmux-dont-write-start-unit-indicator-twice into main

Client discovered pixelation in some viewers, and errors in other.

"when a TS packet with no payload is inserted to carry the PCR just after the begining of a PES packet. The muxer, in this case, is setting the PES start flag not only in the correct TS (where the PES actually starts) but also in the following one"

We traced it to this chain of functions: tsmux_write_stream_packet calls tsmux_write_ts_header (with packet_start_unit_indicator=true), then it calls tsmux_packet_out which might call tsmux_write_ts_header again

Merge request reports