Skip to content

tsmux: avoid overflow when using SCTE NULL interval, and other intervals

Yury Shatz requested to merge jurijs.satcs/gstreamer:tsmux-scte-interval-overflow into main

When SCTE null interval is more than 160s, value of PROP_SCTE_NULL_INTERVAL is 90000*160, multiplication of program->scte35_null_interval * 300 leads to uint overflow, and value of next_scte35_pcr is calculated incorrectly.

There is the same problem with si_interval, pmt_interval, pat_interval, pcr_interval. Admittedly it is less likely in real life, but their respective properties in mpegtsmux all have range up to MAX_UINT.

Merge request reports