Skip to content

videoconvertscale: handle 1/INT_MAX

Tim Blechmann requested to merge timblechmann/gstreamer:feature/prevent-overflow into main

Some v4l2 drivers (most notably the virtual video test driver vivid) seem to report a pixel-aspect-ratio of 1/INT_MAX (which the dot representation seems to interpret as NULL). This causes an integer overflow in videoconvertscale. To prevent this, we interpret 1/INT_MAX as 1/1

Reproducer:

gst-launch-1.0 v4l2src device=/dev/video2 ! 'video/x-raw, width=1920,
height=1080' ! videoconvertscale ! appsink
caps="video/x-raw,pixel-aspect-ratio=1/1"

Merge request reports