Skip to content

ges/nle: Use internal messages where it makes sense.

Thibault Saunier requested to merge thiblahute/gstreamer:nle_use_bus_message_instead_of_recursing_up into main

  • nle: Use a message/event based mechanism to detect parent nleobject duration
    Recursing up is pretty ugly and will fail when we start using ancillary
    pipelines for sources in nle, using a message/event based mechanism is
    a common pattern that is much cleaner.

  • ges: Keep internal stream selection messages internally
    Timeline StreamCollection are very specific to inner working of nested
    timelines and should not interfere with the usual stream selection
    process and are now handled as element messages.

    Stream selection inside nleobject need to be handled internally by the
    application or GES itself so we should just drop all those as they would
    interfere and fail if they are exposed to other elements.

  • nlecomposition: Use a message to check if we need an initialization seek Subtimeline might be in an auxiliary pipeline which make the current recurse up approach not working.

  • nlecomposition: Use a bus message to retrieve pipeline position
    Instead of recursing up, as this will allow to have nested composition
    run inside auxiliary pipelines. It is a bit cleaner also.

Edited by Thibault Saunier

Merge request reports