Skip to content

audioaggregator: Make access to the pad list thread-safe while mixing

Sebastian Dröge requested to merge slomo/gstreamer:audioaggregator-pad-race-conditions into main

When mixing every single buffer the object lock is shortly released and acquired again. In the meantime the pad list can become invalid because a pad was removed or added, and equally the current pad might as well have been finalized in the meantime.

To get around that, take a snapshot of all sinkpads before mixing and work with that list of pads.

Fixes #3052 (closed)

And some follow-up fixes in aggregator itself.

Merge request reports