Skip to content

webrtcdsp: Fix some regressions during the port to 1.1

Nirbheek Chauhan requested to merge nirbheek/gstreamer:webrtcdsp-regression into main 
webrtcdsp: Read from probe only after setup is complete

Otherwise everything fails horribly:

GStreamer-Audio-CRITICAL **: 15:48:41.739: gst_buffer_add_audio_meta: assertion 'GST_AUDIO_INFO_IS_VALID (info)' failed
ERROR: from element /GstPipeline:call-202984728304/GstWebrtcDsp:webrtcdsp0: Echo Probe has rate 0 , while the DSP is running at rate 48000, use a caps filter to ensure those are the same.
Additional debug info:
../subprojects/gst-plugins-bad/ext/webrtcdsp/gstwebrtcdsp.cpp(399): gst_webrtc_dsp_analyze_reverse_stream (): /GstPipeline:call-202984728304/GstWebrtcDsp:webrtcdsp0
webrtcdsp: Map probe buffers with probe info, not dsp info

The probe's info may not precisely match the dsp's info. For instance,
the number of channels or their layout might be different.

GStreamer-Audio-CRITICAL **: 16:21:32.899: the GstAudioInfo argument is not equal to the GstAudioMeta's attached info

This broke in !2943 (merged)

Merge request reports