Skip to content

videoflip: fix setting of method property at construction time

Mathieu Duponchelle requested to merge meh/gstreamer:videoflip-construct-fix into main

Since c2f890ab, element properties are gathered from the parse-launch line and passed at object construction.

This caused the following issue to happen in videoflip:

  • videoflip installed a CONSTRUCT property named method, now deprecated
  • videoflip now also overrides that property with a video-direction property

GObject construction causes method to be set first at construct time, with the user-provided value, then video-direction with the default value.

The user-provided value was thus overridden, causing a regression.

Fix by not installing the properties as CONSTRUCT, and explicitly implementing constructed() instead in order to ensure that we do still call gst_video_flip_set_method() at least once during construction.

Fixes #2529 (closed)

Merge request reports