Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.1k
    • Issues 1.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 493
    • Merge requests 493
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gstreamergstreamer
  • Merge requests
  • !4257

rtspsrc: don't interrupt TEARDOWN on stopping

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Alexander Slobodeniuk requested to merge aslobodeniuk/gstreamer:rtspsrc-avoid-cleanup-race into main Mar 23, 2023
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

This is a workaround that prevents race condition "rtspsrc_connection_flush vs rtspsrc_cleanup".

In case of rtsp redirection it may happen, that tearing down the first url will be interrupted by state change to NULL. This triggers a race condition: gst_rtsp_connection_flush will iterate "src->streams", and at the same time gst_rtsp_cleanup may free this list.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rtspsrc-avoid-cleanup-race