Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.1k
    • Issues 1.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 493
    • Merge requests 493
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gstreamergstreamer
  • Merge requests
  • !4235

v4l2videoenc: ensure OUTPUT buffer pool is activated if processing thread is running

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Michael Tretter requested to merge m.tretter/gstreamer:v4l2enc-reconfigure-copy-mode into main Mar 21, 2023
  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 1

A RECONFIGURE event may trigger an allocation query from upstream on the v4l2jpegenc event. If the format is the same, the format on the encoder is not changed and the processing thread running.

In this case, the element should switch to copy mode to avoid costly reallocation of the V4L2 buffers.

As the processing thread of the element is not stopped, it doesn't have to be restarted. However, the internal pool may have been deactivated by an upstream element.

The v4l2videoenc always has to ensure that the CAPTURE pool is active when a buffer arrives.

Fixes: #1782

Edited Mar 21, 2023 by Michael Tretter
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4l2enc-reconfigure-copy-mode