Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1.1k
    • Issues 1.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 499
    • Merge requests 499
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gstreamergstreamer
  • Merge requests
  • !4230

v4l2videoenc: always allocate CAPTURE buffer from our pool

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Michael Tretter requested to merge m.tretter/gstreamer:v4l2enc-do-not-copy-capture-buffer into main Mar 20, 2023
  • Overview 5
  • Commits 1
  • Pipelines 4
  • Changes 1

The videoencoder base class always uses the negotiated allocator for allocating coded buffers and ignores the negotiated buffer pool. Therefore, the v4l2videoenc always has to copy buffers from the pool into the allocated output buffers.

This breaks downstream elements that want to import the CAPTURE buffers of the v4l2videoenc, since the v4l2videoenc copies the exported the CAPTURE buffers and sends the copies downstream.

Always use the CAPTURE buffer pool for acquiring CAPTURE buffers instead of allocating the buffers in the base class.

Fixes: #2387

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4l2enc-do-not-copy-capture-buffer