Skip to content

bin: Do not deactivate pads in NULL_TO_READY

Thibault Saunier requested to merge thiblahute/gstreamer:bin_deactivate into main

Since b76d3365 pads are deactivated when going to READY but in uridecodebin(3), the sources source pads are activated while in NULL state (when PULL mode is supported), meaning that we are ending up deactivating those pads in NULL_TO_READY, breaking the pipeline.

The intent of the commit mentioned above is to ensure that the pads are deactivated either in PAUSED_TO_READY or READY_TO_READY, so it should be safe to avoid deactivating in NULL_TO_READY (which make no sense to me).

I am not convinced it is normal for uridecodebin and uridecodebin3 to end up activating the sources pads before ensuring the source elements are not in a state > READY but it is how it is and nothing prevents that so I thought it should be a good thing to ensure that works.

Edited by Thibault Saunier

Merge request reports