Skip to content

bin, iterator: Fix some cosmetic core things, and one potential ref leak.

Jan Schmidt requested to merge thaytan/gstreamer:core-fixes into main

commit 5d61db51 (HEAD -> core-fixes) Author: Jan Schmidt jan@centricular.com Date: Sat Oct 1 04:58:04 2022 +1000

gstbin: Use g_queue_clear_full()

Use g_queue_clear_full() to release the child list
instead of iterating over the list twice.

commit e8b564fa Author: Jan Schmidt jan@centricular.com Date: Sat Oct 1 04:55:49 2022 +1000

gstbin: Fix a potential leak in gst_bin_do_deep_add_remove()

If a child element of a bin is unparented while
gst_bin_do_deep_add_remove() is iterating the children,
don't leak a ref to it.

commit 4fe912f1 Author: Jan Schmidt jan@centricular.com Date: Sat Oct 1 04:54:20 2022 +1000

gstiterator: Don't use gst_object_unref() for a GObject

The owner of a GstIterator is a plain GObject. Don't unref it
with gst_object_unref(), or it will be logged in tracer
info incorrectly.

Merge request reports