Skip to content

xvimagesink: Several fixes for memory leaks and a spurious crash

Jan Schmidt requested to merge thaytan/gstreamer:xvimagesink-fixes into main

commit 0a385bbf Author: Jan Schmidt jan@centricular.com Date: Sat Oct 1 04:51:21 2022 +1000

xvimagesink: Don't leak XvShmImage

If allocating an XvShmImage generates an X error, but
still returns some allocated memory, make sure to free it
so it doesn't leak.

commit f215aa09 Author: Jan Schmidt jan@centricular.com Date: Sat Oct 1 04:49:16 2022 +1000

xvimagesink: Zero initialize mask array

Clear the stack array before setting bits to pass to
XISelectEvents(). Fixes spurious crash from an X error:

X Error of failed request:  BadValue (integer parameter out of range for operation)

commit f7e4f105 Author: Jan Schmidt jan@centricular.com Date: Sat Oct 1 04:47:31 2022 +1000

xvimagesink: Don't leak temporary

Use a stack variable instead of a temporarily
malloced variable that wasn't being freed
properly. Fixes a small leak of a GstXvTouchDevice

Merge request reports