Skip to content

player/play: Fix object construction and various leaks

Sebastian Dröge requested to merge slomo/gstreamer:player-leaks into main 
commit c05682c29057c986117be25ad51472a75e4404ee (HEAD -> player-leaks, gitlab-slomo/player-leaks)
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Aug 13 11:50:20 2022 +0300

    play: Make ownership of video-sink clearer in combination with floating references
    
    And correctly handle the case of VideoRenderer::create_video_sink() not
    actually returning a floating reference, which might be tricky for some
    bindings.

commit be0c9bdc75b21c1772b66f9f870f21138300fc68
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Aug 13 11:49:08 2022 +0300

    play: Fix object construction
    
    Ideally new() functions should simply call g_object_new() and not much
    else, so let's do that here and handle all the construction properly in
    a GObject way.
    
    Now a play object created via g_object_new() is actually usable.

commit 02bae403e70e1ce8e5376b22aebae8da378ad809
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Aug 13 11:42:21 2022 +0300

    player: Fix leak of wrapper video renderer

commit 375746cd1937fd7e5919ab55abfdea29667423f6
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Aug 13 11:39:59 2022 +0300

    player: Fix object construction
    
    Ideally new() functions should simply call g_object_new() and not much
    else, so let's do that here and handle all the construction properly in
    a GObject way.
    
    Now a player object created via g_object_new() is actually usable.
    
    In addition, also fix the video-renderer property so that reading it
    returns an object of the correct type.

commit 92bde1b02830313603358c9d29cc278eecb516ea
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Aug 13 11:30:35 2022 +0300

    player: Release signal adapter on finalize

Merge request reports