Skip to content

rtspurl: Use gst_uri_join_strings() in gst_rtsp_url_get_request_uri_with_control() instead of a hand-crafted, wrong version

Sebastian Dröge requested to merge slomo/gstreamer:rtspsrc-control-url-usage into main 
commit d48c59ae092f24661b7cfdcfeeb73f9e9871c978 (HEAD -> rtspsrc-control-url-usage, gitlab-slomo/rtspsrc-control-url-usage)
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri Aug 12 13:20:01 2022 +0300

    rtspsrc: Consider the actual control base URI also in case the connection URI contains a query string
    
    That is, get rid of unnecessary and wrong special-casing.
    
    This could always use gst_rtsp_url_get_request_uri_with_control() but as
    we only have the control base URI as string it is easier to just call
    gst_uri_join_strings().

commit 6c5deb70ad0903ca94460a29f2c1f83f3752c2f2
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri Aug 12 13:16:50 2022 +0300

    rtspurl: Use gst_uri_join_strings() in gst_rtsp_url_get_request_uri_with_control() instead of a hand-crafted, wrong version
    
    For example the query string of the base must not be taken over to the
    request URL unless there is no control path, and control paths can be
    absolute and must not be considered relative if they start with a /.
    
    Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/971

commit e4a4d91e817c67e291dc2a7f7e0918ef0fe9a490
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri Aug 12 13:15:46 2022 +0300

    rtspurl: Use fail_unless_equals_string() in tests

Regression from gst-plugins-good!349 (merged) CC @boxerab

Edited by Sebastian Dröge

Merge request reports