Skip to content

gst: Protect initialization state with a recursive mutex

Sebastian Dröge requested to merge slomo/gstreamer:gst-init-recursive into main 
commit 590e46ba21a39554246f48b81e098e0974ad206f (HEAD -> gst-init-recursive, gitlab-slomo/gst-init-recursive)
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Jul 9 17:04:07 2022 +0300

    gst: Protect initialization state with a recursive mutex.
    
    Otherwise a gst_init() call from a plugin would deadlock if the plugin
    is loaded as part of registry updating.
    
    Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/940

commit 92d037ec15de305786abc4e30978376530e94f78
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Jul 9 17:02:26 2022 +0300

    registry: Remove dead code
    
    Initialization/updating of the registry can't possible fail and all code
    paths always returned TRUE.

commit b16ffb97c4fc8bbc163e66e3d0e03abbd85077de
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Jul 9 16:50:54 2022 +0300

    gst: Don't fail gst_init() if updating the registry fails
    
    Everything is already marked as initialized at that point and by failing
    no tracers would be loaded or plugin feature rank overrides would be
    applied.

CC @tpm @thiblahute

Edited by Sebastian Dröge

Merge request reports