Skip to content

rtpopusdepay: missing sprop-stereo should not assume mono

Tristan Matthews requested to merge tmatth/gstreamer:bugfix/no-force-mono-missing-sprop into main

Commit 8f696942 assumed that if sprop-stereo was omitted, this meant we could assume mono, but from https://datatracker.ietf.org/doc/html/draft-ietf-payload-rtp-opus-11 the wording is:

This is not a guarantee that the sender will never send stereo audio (e.g. it could send a pre-recorded
prompt that uses stereo), but it indicates to the receiver that the received signal can be safely downmixed
to mono.

which suggests that the signal could very well still be stereo.

Fixes #1064 (closed)

Edited by Tristan Matthews

Merge request reports