Skip to content

webrtcbin: fix deadlock when setting up FEC encoder

We bind transceivers' fec_percentage property to the FEC encoder percentage property, and with the binding bidirectional a deadlock was introduced by the latest changes from !1762 (merged):

We take hold of the transceiver's object lock, then add the binding and set the property to its initial value on the encoder, which causes set_property to deadlock in the transceiver when the binding kicks in.

Changing the binding type to DEFAULT (source to target) is enough to address the deadlock and still serves the original intent.

Merge request reports